Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After unsubscribing from a subscription on web, can't unscribe from more until page refresh #3648

Closed
WillTwait opened this issue Mar 7, 2024 · 2 comments
Closed

After unsubscribing from a subscription on web, can't unscribe from more until page refresh #3648

WillTwait opened this issue Mar 7, 2024 · 2 comments
Assignees
@jacksonh
Labels
Web

Comments

@WillTwait
Copy link

repro:

  • unsub from a subscription in /settings/subscriptions
  • can no longer click ... button to unsub from more
  • refresh page, and buttons are now clickable
@jacksonh jacksonh self-assigned this Mar 8, 2024
@jacksonh jacksonh added the Web label Mar 8, 2024
@jacksonh
Copy link
Contributor

jacksonh commented Mar 8, 2024

I suspect this is related to a bug we've seen in our modals library, thanks for reporting.

egrajeda added a commit to egrajeda/omnivore that referenced this issue Mar 23, 2024
@egrajeda
fix: page becomes unresponsive after closing modal
712cad9 
Came across this issue while migrating to Omnivore, but I saw it also
reported in issue omnivore-app#3648. There was a first attempt to fix in omnivore-app#3653, but
I believe it's an issue in the library itself, which is not there
anymore in 2.0.6.

It also fixes the "too much recursion" error that shows in the console
when the modal is open, both in the Feeds page and in the Inbox (e.g.
when clicking on Edit Info).
@egrajeda egrajeda mentioned this issue Mar 23, 2024
Merged
@jacksonh
Copy link
Contributor

Deploying a fix for this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacksonh jacksonh

Labels
Web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacksonh @WillTwait