fix memory leak

omochi · Jan 13, 2019 · 633fdc3 · 633fdc3
1 parent 7ad0a27
commit 633fdc3
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/Sources/OrderedDictionary/LinkedListObject.swift b/Sources/OrderedDictionary/LinkedListObject.swift
@@ -6,7 +6,7 @@ public class LinkedListObject<T> {
 
         internal weak var owner: LinkedListObject?
         internal var next: Node?
-        internal var previous: Node?
+        internal weak var previous: Node?
 
         internal init(_ value: T,
                       owner: LinkedListObject?)

diff --git a/Tests/OrderedDictionaryTests/LinkedListObjectTests.swift b/Tests/OrderedDictionaryTests/LinkedListObjectTests.swift
@@ -84,4 +84,29 @@ class LinkedListObjectTests: XCTestCase {
 
         XCTAssertEqual(revActual, expected.reversed(), file: file, line: line)
     }
+
+    class Obj {
+        static var count: Int = 0
+
+        init() {
+            Obj.count += 1
+        }
+
+        deinit {
+            Obj.count -= 1
+        }
+    }
+
+    func testLeak() {
+        do {
+            let a = LinkedListObject<Obj>()
+
+            a.append(Obj())
+            a.append(Obj())
+
+            XCTAssertEqual(Obj.count, 2)            
+        }
+
+        XCTAssertEqual(Obj.count, 0)
+    }
 }
diff --git a/Tests/OrderedDictionaryTests/LinkedListTests.swift b/Tests/OrderedDictionaryTests/LinkedListTests.swift
@@ -97,5 +97,4 @@ class LinkedListTests: XCTestCase {
 
         XCTAssertEqual(revActual, expected.reversed(), file: file, line: line)
     }
-
 }