Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making website logo clickable. #123

Closed
wants to merge 2 commits into from

Conversation

Narendra9906
Copy link

@Narendra9906 Narendra9906 commented May 18, 2024

Pull Request Details #73

Description

Making website logo clickable. Whenever user click on the logo they will be land on the Home page of the website.

[Provide a brief overview of the changes introduced by this pull request.]

In this update, the functionality of the website logo has been enhanced to improve user navigation.
The changes were made in logo component. Inside logo.tsx file the Topography component, which renders the logo, has been wrapped in the anchor tag. The href attribute of the anchor tag has been set to "https://www.bigohhh.com/", which is the url of the homepage. This means when user clicks on the logo they will be redirected to the hompage.
Please note that the onCLick prop as its related to inrtergace declaration have been removed from the Logo component as they are no longer needed. This is a non-breaking chnages as it adds functionality in a backwards-compatible manner, as it does not affect any existing behaviour of the Logo Component.

Fixes

[Cite any related issues or bugs that this PR addresses, e.g., "Fixes #123"]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Refactoring
  • Other (specify): _______________

Screenshots (if applicable)

[If your changes include UI updates, provide screenshots to illustrate the changes.]

Additional Notes

[Include any additional information or context that might be helpful for reviewers.]

Checklist

  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, snapshots, and videos after making the changes.
  • I have not borrowed code without disclosing it, if applicable.
  • This pull request is not a Work In Progress (WIP), and only completed and tested changes are included.
  • I have tested these changes locally.

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bigohhh-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:32pm
bigohhh-com-z1v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:32pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@omrajsharma
Copy link
Owner

Hi @Narendra9906
I'm unable to test this feature in the above link. It seems to be non clickable

</Typography>
</Typography>
</a>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this space

Copy link
Author

@Narendra9906 Narendra9906 May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo tsx Okay, @omrajsharma. Could you also tell me how to fix this? I added an tag (i.e., anchor element) inside the element. I set the path of the tag to https://www.bigohhh.com/. Could you please guide me? This is my first time contributing. I am newbies.

I removed the space. Please check it. If it’s okay, then I will have to send you another pull request.
import React, { FC } from 'react'
import { Box, Typography } from '@mui/material'

interface Props {
onClick?: () => void
variant?: 'primary' | 'secondary'
}

const Logo: FC = ({ variant }) => {
return (

<a href="https://www.bigohhh.com/" style={{ textDecoration: 'none' }}>
<Typography
variant="h4"
component="h1"
sx={{ fontWeight: 700, '& span': { color: variant === 'primary' ? 'primary.main' : 'unset' } }}
>
BigOhhh



)
}
Logo.defaultProps = {
variant: 'primary',
}
export default Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants