python36 xfail test: use pickle.dumps instead of pickle.dump

omry · Oct 6, 2021 · 7fb6fe5 · 7fb6fe5
1 parent 79b5d2b
commit 7fb6fe5
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/tests/test_serialization.py b/tests/test_serialization.py
@@ -322,13 +322,12 @@ def test_pickle_backward_compatibility(version: str) -> None:
 @mark.xfail(reason="python3.6 pickling error is not handled")
 def test_python36_pickle_optional() -> None:
     cfg = OmegaConf.structured(SubscriptedDictOpt)
-    with tempfile.TemporaryFile() as fp:
-        with raises(
-            OmegaConfBaseException,
-            match=re.escape(
-                "Serializing structured configs with `Union` type annotations requires python >= 3.7"
-            ),
-        ):
-            # currently this raises the following:
-            # _pickle.PicklingError: Can't pickle typing.Union[int, NoneType]: it's not the same object as typing.Union
-            pickle.dump(cfg, fp)
+    with raises(
+        OmegaConfBaseException,
+        match=re.escape(
+            "Serializing structured configs with `Union` type annotations requires python >= 3.7"
+        ),
+    ):
+        # currently this raises the following:
+        # _pickle.PicklingError: Can't pickle typing.Union[int, NoneType]: it's not the same object as typing.Union
+        pickle.dumps(cfg)