to_container of string interpolation with readonly parent

omry · Jun 20, 2020 · e80bce8 · e80bce8
1 parent 70bd144
commit e80bce8
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/news/275.bugfix b/news/275.bugfix
@@ -0,0 +1 @@
+Fix OmegaConf.to_container() failing in some cases when the config is read-only
diff --git a/omegaconf/nodes.py b/omegaconf/nodes.py
@@ -18,8 +18,11 @@ class ValueNode(Node):
     _val: Any
 
     def __init__(self, parent: Optional[Container], value: Any, metadata: Metadata):
+        from omegaconf import read_write
+
         super().__init__(parent=parent, metadata=metadata)
-        self._set_value(value)
+        with read_write(self):
+            self._set_value(value)
 
     def _value(self) -> Any:
         return self._val

diff --git a/tests/test_base_config.py b/tests/test_base_config.py
@@ -181,6 +181,15 @@ def test_to_container(src: Any, expected: Any, expected_with_resolve: Any) -> No
     assert container == expected_with_resolve
 
 
+def test_string_interpolation_with_readonly_parent() -> None:
+    cfg = OmegaConf.create({"a": 10, "b": {"c": "hello_${a}"}})
+    OmegaConf.set_readonly(cfg, True)
+    assert OmegaConf.to_container(cfg, resolve=True) == {
+        "a": 10,
+        "b": {"c": "hello_10"},
+    }
+
+
 @pytest.mark.parametrize(  # type: ignore
     "src,expected",
     [

diff --git a/tests/test_nodes.py b/tests/test_nodes.py
@@ -16,7 +16,7 @@
     StringNode,
     ValueNode,
 )
-from omegaconf.errors import ValidationError
+from omegaconf.errors import ReadonlyConfigError, ValidationError
 
 from . import Color