Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OmegaConf.select() with relative keys #656

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

omry
Copy link
Owner

@omry omry commented Apr 1, 2021

I am not including a news fragment because relative interpolations are new in 2.1.

param(
{"user@domain": 10, "foo": "${user@domain}"}, "foo", 10, id="user@domain"
),
# relative interpolations
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tests starts here.

Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@omry omry merged commit 2c48e60 into master Apr 1, 2021
@omry omry deleted the select_relative branch April 1, 2021 22:04
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants