Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor built-in resolvers #676

Merged
merged 2 commits into from
Apr 11, 2021
Merged

refactor built-in resolvers #676

merged 2 commits into from
Apr 11, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Apr 11, 2021

Reorganizing built-in resolvers.

I am also thinking about an alternative layout with a single file per module:

oc/__init__.py # oc module
oc/dict.py    # oc.dict module 

@omry omry requested review from odelalleau and Jasha10 April 11, 2021 08:01
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! (not sure we care about defining __all__ but why not)

@omry
Copy link
Owner Author

omry commented Apr 11, 2021

if you just import in init and not use it's triggering a lint warning

Oh I see -- I didn't realize that.

the alternative layout should probably eliminate the need for it

New layout works for me too.

Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@omry omry changed the title refactor build-in resolvers refactor built-in resolvers Apr 11, 2021
@omry
Copy link
Owner Author

omry commented Apr 11, 2021

Switched to new layout, I think it's significantly cleaner.

@omry omry merged commit 72ae5aa into master Apr 11, 2021
@omry omry deleted the refactor-resolvers branch April 11, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants