Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ListConfig.append to use _set_item_impl #740

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Updated ListConfig.append to use _set_item_impl #740

merged 2 commits into from
Jun 4, 2021

Conversation

omry
Copy link
Owner

@omry omry commented Jun 3, 2021

No description provided.

omegaconf/listconfig.py Outdated Show resolved Hide resolved
@odelalleau odelalleau self-requested a review June 3, 2021 22:33
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@omry omry merged commit 6c732c1 into master Jun 4, 2021
@omry omry deleted the 601-update branch June 4, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants