-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reviews for in-app sales #41
Comments
Create a Fork within Github, clone that repository, make your changes, and commit. Then, send us a pull request. :) |
I'll do so as soon as I get a chance. Thanks! |
I have done this and have it working but no one is responding to my pull requests |
I can't figure out how to handle a pull request in git and haven't had time to try again. Do you know of a straightforward guide? Github's help page's instructions don't work for me. |
Nope never had chance did I send the pull request properly? |
http://www.viget.com/extend/i-have-a-pull-request-on-github-now-what/ Just found this... Looks like it's quite simple... |
Figured it out. That guide is way overcomplicated for a patch that applies cleanly; you can just go to your Fork Queue, click the checkboxes next to the commits, and click Apply. Done! I've accepted your changes. |
This needs to be reopened... changes have overwritten my changes... |
Sorry about that, Paul. I did a huge merge with another tree and must have clobbered some part of it accidentally despite attempting to make it clean. Would it be possible for you to merge with the main repository and send a pull request after you've reapplied whatever change was clobbered? |
I am trying to figure out what has changed... it seems that the whole reports.m has changed... will look into it! :) |
Reviews for in-app sales are copies of reviews for the app in which they appear, so having them download and appear in the list of reviews is a waste of time and resources.
I am happy to make the change that excludes in-app purchases from the code that grabs reviews online if someone would provide the information I need to get those changes into the main code branch or get those changes to the developer so that he can commit them. I don't want to have local changes to the code that don't carry over to new revisions.
The text was updated successfully, but these errors were encountered: