Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server cannot start when JIDO_API_PORT env var is set #12

Closed
patrixl opened this issue Mar 31, 2016 · 2 comments
Closed

Server cannot start when JIDO_API_PORT env var is set #12

patrixl opened this issue Mar 31, 2016 · 2 comments
Assignees
@aw
Labels
bug

Comments

@patrixl
Copy link
Member

patrixl commented Mar 31, 2016

When JIDO_API_PORT environment variable is set, the http server cannot start:

$ JIDO_API_PORT=8888 ./run.l
HTTP listening on port: 8888
[app.l:26] !? (port *Port)
"8888" -- Bad argument

This happens because *JIDO_API_PORT is a string rather than a number, when the environment variable is loaded.
@patrixl patrixl added the bug label Mar 31, 2016
patrixl pushed a commit to patrixl/jidoteki-admin-api that referenced this issue Mar 31, 2016
Fix issue on-prem#12 by formatting the JIDO_API_PORT environment vari…
6fde4b4 
…able as a number, or NIL if a string
@aw
Copy link
Member

aw commented Mar 31, 2016

😮 I have no idea how this went over me... good catch!

aw added a commit that referenced this issue Mar 31, 2016
@aw
Add regression test for #12
196aa59
aw added a commit that referenced this issue Mar 31, 2016
@aw
Add regression tests for #12. Fix tests for x86_64
da626c6
@aw aw self-assigned this Mar 31, 2016
@aw
Copy link
Member

aw commented Mar 31, 2016

Fixed and rebased with my regression tests. Thanks for the bug report!

@aw aw closed this as completed Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aw aw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aw @patrixl