Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47944 Improvement of the address list functionality - Add form selection (3) #819

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dai-eastgate
Copy link
Contributor

related to #807
changed log:
Add form selection

@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9575950787

Details

  • 187 of 231 (80.95%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 79.703%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/DataView/DataAddressDetailView.php 15 16 93.75%
plugin/DataView/DataAddressDetailViewHandler.php 18 19 94.74%
plugin/Controller/AdminViewController.php 10 12 83.33%
plugin/Model/FormModelBuilder/FormModelBuilderAddressDetailSettings.php 103 113 91.15%
plugin/Controller/DetailViewPostSaveController.php 20 50 40.0%
Files with Coverage Reduction New Missed Lines %
plugin/Controller/DetailViewPostSaveController.php 1 46.34%
Totals Coverage Status
Change from base Build 9563894875: 0.08%
Covered Lines: 8521
Relevant Lines: 10691

💛 - Coveralls

@fredericalpers fredericalpers added QA Issue or Pull request that is in review component: address list Issue, Pull Request or Discussion related to address lists labels Jun 7, 2024
@fredericalpers fredericalpers added this to the v4.24 milestone Jun 7, 2024
@fredericalpers fredericalpers added the feature New feature label Jul 1, 2024
@fredericalpers fredericalpers linked an issue Jul 1, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: address list Issue, Pull Request or Discussion related to address lists feature New feature QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement of the address list functionality - Add form selection (3)
3 participants