Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove div #849

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Remove div #849

merged 2 commits into from
Jul 9, 2024

Conversation

andernath
Copy link
Contributor

In version 4.20 some minor styling issues occured because of changes in: #738

Also adding a div automatically to template is bad practice, because user can not edit this.
See: #4327415

I think the multi pagination will also work without a div container.

@andernath andernath added the deploy test Triggers event to create test version label Jul 2, 2024
@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9757664772

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 79.557%
Totals Coverage Status
Change from base Build 9739943038: -0.004%
Covered Lines: 8328
Relevant Lines: 10468
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Steps to install the approved version:

  1. Download onoffice-4.20-5-g39dee1da-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/9757772483.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Jul 2, 2024
@fredericalpers fredericalpers added this to the v4.21 milestone Jul 2, 2024
@fredericalpers fredericalpers mentioned this pull request Jul 2, 2024
Open
3 tasks
@fredericalpers
Copy link
Contributor

@andernath Das kann so erstmal als Fix released werden. Für das Problem mit der "Theme-Paginierung" habe ich ein weiteres Issue erstellt. #850

@andernath andernath merged commit b9191e7 into master Jul 9, 2024
9 checks passed
@andernath andernath deleted the 4327415-remove-div-in-shortcode branch July 9, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy test Triggers event to create test version QA Issue or Pull request that is in review
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andernath @coveralls @fredericalpers