Changing the speed unit has no effect

[claustres]

Value is always in m/s and m/s is always displayed in the UI even if the speedUnit: 'kt' option is set.

This is linked to the fact that the merge of PR #8 in commit 38fe1a4 was not completly right, see 38fe1a4#commitcomment-25654602.

The correct code as seen in my fork is the following:

if(gridValue && !isNaN(gridValue[0]) && !isNaN(gridValue[1]) && gridValue[2]) {
  htmlOut = "<strong>"+ this.options.velocityType +" Direction: </strong>"+  self.vectorToDegrees(gridValue[0],gridValue[1],this.options.angleConvention).toFixed(2) + "°" +
            ", <strong>"+ this.options.velocityType +" Speed: </strong>" + self.vectorToSpeed(gridValue[0],gridValue[1],this.options.speedUnit).toFixed(2) + this.options.speedUnit;
}

Since on my side the merge has been correct on my master it is not easy to create a specific PR for this, would you mind reporting it directly in your master branch ?

Thanks.

[SFSailor]

Good fix. I did an "include" to make this work with my app.

[danwild]

Thanks, fixed in cd565bd.

[SFSailor]

Thank you. It's a great program.

…

On Sun, Dec 17, 2017 at 8:33 PM, Dan Wild ***@***.***> wrote: Closed #18 <#18>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Af9OqHJZP2zWCmPerBkI5M7KvPKd6xpxks5tBesUgaJpZM4Qgg8u> .