Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1216 view details url bug #1218

Closed
wants to merge 12 commits into from
Closed

Conversation

mutuajames
Copy link
Contributor

addParams now checks if we've appended a url before appending another.
#closes 1216

@codecov-commenter
Copy link

Codecov Report

Merging #1218 (7f653ce) into master (145a4d9) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
- Coverage   95.03%   95.02%   -0.01%     
==========================================
  Files         320      320              
  Lines        9348     9350       +2     
  Branches     2029     2030       +1     
==========================================
+ Hits         8884     8885       +1     
- Misses        456      457       +1     
  Partials        8        8              
Impacted Files Coverage Δ
packages/react-utils/src/hooks/useSearchParams.ts 90.47% <50.00%> (-4.27%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mutuajames mutuajames closed this Jun 22, 2023
@mutuajames mutuajames deleted the 1216-view-details-url-bug branch June 22, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants