Skip to content

Commit

Permalink
Revert "Update functions to 3.0" (Azure#4898)
Browse files Browse the repository at this point in the history
Reverts Azure#4856

I believe this change broke CI and checkin pipeline. https://dev.azure.com/msazure/One/_build/results?buildId=41761951&view=results
  • Loading branch information
vadim-kovalyov committed Apr 26, 2021
1 parent 49520f3 commit 3ab67a3
Show file tree
Hide file tree
Showing 13 changed files with 20 additions and 13 deletions.
1 change: 0 additions & 1 deletion CodeCoverage.runsettings
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ Included items must then not match any entries in the exclude list to remain inc
<ModulePath>.*testanalyzer\..*</ModulePath>
<ModulePath>.*testresultcoordinator\..*</ModulePath>
<ModulePath>.*twintester\..*</ModulePath>
<ModulePath>.*microsoft.azure.webjobs.*</ModulePath>
</Exclude>
</ModulePaths>

Expand Down
1 change: 1 addition & 0 deletions builds/checkin/dotnet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
pool:
vmImage: "ubuntu-18.04"
steps:
- template: ../templates/install-dotnet2.yaml
- template: ../templates/install-dotnet3.yaml
- task: Bash@3
displayName: Install Prerequisites
Expand Down
1 change: 1 addition & 0 deletions builds/ci/dotnet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
IotDevice3ConnStr2,
IotHubConnStr2,
IotHubMqttHeadCert
- template: ../templates/install-dotnet2.yaml
- template: ../templates/install-dotnet3.yaml
- task: Bash@3
displayName: Install Prerequisites
Expand Down
1 change: 1 addition & 0 deletions builds/misc/images-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
docker login '$(build.registry.address)' --username '$(build.registry.user)' --password '$(build.registry.password)'
docker login '$(registry.address)' --username '$(registry.user)' --password '$(registry.password)'
displayName: 'Docker Login'
- template: ../templates/install-dotnet2.yaml
- template: ../templates/install-dotnet3.yaml
- template: ../templates/dotnet3-globaljson.yaml # use dotnet 3 as primary install for build
# Build
Expand Down
1 change: 1 addition & 0 deletions builds/misc/images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
pool:
vmImage: 'ubuntu-18.04'
steps:
- template: ../templates/install-dotnet2.yaml
- template: ../templates/install-dotnet3.yaml

- bash: 'docker login $(registry.address) --username $(registry.user) --password $(registry.password)'
Expand Down
6 changes: 6 additions & 0 deletions builds/templates/install-dotnet2.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
steps:
- task: UseDotNet@2
displayName: Install .NET Core sdk
inputs:
packageType: sdk
version: 2.2.207
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="..\..\..\..\netcoreappVersion.props" />
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>

<PropertyGroup>
<AzureFunctionsVersion></AzureFunctionsVersion>
Expand All @@ -19,7 +21,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Sdk.Functions" Version="3.0.9" />
<PackageReference Include="Microsoft.NET.Sdk.Functions" Version="1.0.26" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
</ItemGroup>

Expand Down
5 changes: 0 additions & 5 deletions edge-modules/functions/samples/README.md

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/azure-functions/dotnet:3.0
FROM mcr.microsoft.com/azure-functions/dotnet:2.0-iot-edge

ENV AzureWebJobsScriptRoot=/app

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/azure-functions/dotnet:3.0-arm32v7
FROM mcr.microsoft.com/azure-functions/dotnet:2.0-arm32v7

ENV AzureWebJobsScriptRoot=/app

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# escape=`

FROM mcr.microsoft.com/azure-functions/dotnet:3.0-nanoserver-1809
FROM mcr.microsoft.com/azure-functions/dotnet:2.0-nanoserver-1809

COPY . /approot
2 changes: 1 addition & 1 deletion scripts/linux/buildBranch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ publish_app "MetricsValidator"
publish_app "NumberLogger"
publish_app "CloudToDeviceMessageTester"
publish_app "IotedgeDiagnosticsDotnet"
publish_app "EdgeHubTriggerCSharp"

publish_lib "EdgeHubTriggerCSharp"
publish_lib "Microsoft.Azure.WebJobs.Extensions.EdgeHub"

publish_files $SRC_SCRIPTS_DIR $PUBLISH_FOLDER
Expand Down
3 changes: 2 additions & 1 deletion test/Microsoft.Azure.Devices.Edge.Test/Module.cs
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public async Task TempFilter()
TempFilterToCloud = $"FROM /messages/modules/{filterName}/outputs/alertOutput INTO $upstream",
TempSensorToTempFilter = $"FROM /messages/modules/{SensorName}/outputs/temperatureOutput INTO BrokeredEndpoint('/modules/{filterName}/inputs/input1')"
}
});
} );
},
token,
Context.Current.NestedEdge);
Expand All @@ -116,6 +116,7 @@ public async Task TempFilter()
}

[Test]
[Category("Unstable")]
// Test Temperature Filter Function: https://docs.microsoft.com/en-us/azure/iot-edge/tutorial-deploy-function
public async Task TempFilterFunc()
{
Expand Down

0 comments on commit 3ab67a3

Please sign in to comment.