Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typograhy and mixins #226

Closed
wants to merge 0 commits into from
Closed

typograhy and mixins #226

wants to merge 0 commits into from

Conversation

ilanap
Copy link
Collaborator

@ilanap ilanap commented Dec 24, 2017

changes for the typography including fixes for react and angular css

included:

  • added mixins for the different sizes for header and body
  • changes name of font styles to logical name (hover/focus/emphasis) instead of applied font style

@ArielDKenan
Copy link
Collaborator

Classes are being replaced with mixins here to fix issues with typography that components have had. Sometimes using @extend .typo-class wouldn't have the desired effect. Mixins have a clear effect of inserting properties into a class.

@ArielDKenan ArielDKenan mentioned this pull request Dec 24, 2017
@ilanap ilanap closed this Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants