feat: Broadcaster Middleware #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new middleware which will send a bundle to a list of builders
adds broadcaster
onbjerg
approved these changes
May 19, 2023
|
OK great. Lint should pass now. |
|
@onbjerg any reason you haven't merged this yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added a new Broadcaster Middleware which takes a list of builders in the constructor and sends a bundle to each builder when 'send bundle' is called. As it's quite common for searchers to send to more than one builder these days, we feel this could be a useful feature to have. We are happy to discuss further and make any necessary changes.