This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arscan
reviewed
Jan 15, 2020
@@ -306,6 +309,71 @@ def create_search_test(sequence, search_param) | |||
) | |||
end | |||
|
|||
def create_chained_search_test(sequence, search_param) | |||
# NOTE: This test is currently hard-coded because chained searches are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you raise an error in the generator if sequence not for PractionerRole just in case more are added in a future version?
Could you rebase when you have a chance? We can get this one in next. |
Jammjammjamm
force-pushed
the
fi-569-add-chained-search-tests
branch
from
January 16, 2020 15:13
cbb3ff8
to
39f8ba9
Compare
arscan
previously approved these changes
Jan 16, 2020
arscan
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted the transitory build issue, which wasn't resolved. We'll address that later.
For future reference: https://travis-ci.org/onc-healthit/inferno/builds/633422948?utm_medium=notification&utm_source=github_status
Otherwise looks good!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a test for the chained search parameters US Core requires for PractitionerRole (practitioner.name and practitioner.identifier). Although this test was added to the US Core generator, the test itself and its unit test are hard coded. Implementing chained search tests in a generic manner would require a much larger amount of effort and isn't necessary to support these two chained parameters.
Submitter:
Reviewer 1:
Name:
where appropriate, and accomplishes the task's purpose
Reviewer 2:
Name:
where appropriate, and accomplishes the task's purpose