Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-575 Add informational messages from validators to the UI #412

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

okeefm
Copy link

@okeefm okeefm commented Jan 7, 2020

Previously, some messages from the HL7 validator that were at an "informational" level (things like not adhering to recommended valueset bindings, incorrect display names for codes, etc.) were being displayed as "warnings". This PR moves those messages to a separate level with its own icon in the UI, to keep people from stressing over messages that don't rise to the warning level.

The test result list page, indicating the presence of informational messages
Screen Shot 2020-01-07 at 8 24 58 AM

The test result details page, displaying those messages
Screen Shot 2020-01-07 at 8 26 03 AM

Pull requests into Inferno require the following items to be completed. Submitter and reviewer
should check the relevant check boxes when the associated item is done. For items that are not
applicable, note it's not applicable ("N/A") and check the box. For example, external Pull
Requests do not require ticket links.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-575
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@okeefm okeefm changed the title Add informational messages from validators to the UI, separately from warnings FI-575 Add informational messages from validators to the UI Jan 7, 2020
Copy link
Contributor

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of that info icon, but this seems to work fine.

However, it really exposes how we need to update our validation messages to indicate which resource they're associated with now that we're validating multiple resources.

@okeefm
Copy link
Author

okeefm commented Jan 7, 2020

@arscan both @Jammjammjamm and I are not super happy with the icon being used for the information, but we can't find a better one in the Open Iconic iconset. Ideally I'd use something like this: https://fontawesome.com/icons/info-circle?style=solid, but open iconic doesn't seem to have an equivalent. Thoughts?

@arscan arscan merged commit 4d6b310 into development Jan 20, 2020
@arscan arscan deleted the FI-575-informational-validator-messages branch January 20, 2020 18:35
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants