Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-505 Minor updates to allow for multiple urls. #417

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

arscan
Copy link
Contributor

@arscan arscan commented Jan 19, 2020

This gives the test writer a bit more flexibility by allowing the client to be generated from a different property than url. It also loosens up the requirement for duplicate test names to allow for multiple children of the same parent to be in one module.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@arscan arscan changed the title Minor updates to allow for multiple urls. FI-505 Minor updates to allow for multiple urls. Jan 19, 2020
@arscan arscan merged commit 0fe9033 into development Jan 20, 2020
@arscan arscan deleted the fi-505-enable-multi-url branch January 20, 2020 18:33
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant