Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

check for existence of all composite or values #422

Merged
2 commits merged into from
Jan 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2020

This makes the composite or searches check if all values being or'd by are found

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-598
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@ghost ghost force-pushed the fi-598-check-all-composite-or-values branch from ddd3cd6 to 64522ff Compare January 24, 2020 20:48
@ghost ghost merged commit b2c8fde into development Jan 30, 2020
@ghost ghost deleted the fi-598-check-all-composite-or-values branch January 30, 2020 15:45
@radamson radamson mentioned this pull request Aug 9, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant