Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

fix rubocop issues and remove unit tests #424

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2020

This fixes rubocop issues and removes unit tests.
Non-patient sequences will have their old tests and won't loop through patients.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@arscan arscan merged commit 7de4448 into FI-601-mutli-patient-uscore Jan 24, 2020
@arscan arscan deleted the clean-up-multi-patient-changes branch January 24, 2020 19:55
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant