This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Fi 612 fix tests for multi patient #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammjammjamm
reviewed
Feb 6, 2020
| @@ -12,8 +12,8 @@ describe Inferno::Sequence::<%= class_name %> do | |||
| @token = 'ABC' | |||
| @instance = Inferno::Models::TestingInstance.create(url: @base_url, token: @token, selected_module: '<%= module_name %>') | |||
| @client = FHIR::Client.for_testing_instance(@instance) | |||
| @patient_id = 'example' | |||
| @instance.patient_id = @patient_id | |||
| @patient_ids = 'example' | |||
There was a problem hiding this comment.
Is it possible to replace the other locations where 'example' is hard coded with this instance variable?
There was a problem hiding this comment.
Yep good point. All other hardcoded 'example' locations are changed to '@sequence.patient_ids.first'.
Jammjammjamm
approved these changes
Feb 7, 2020
arscan
approved these changes
Feb 7, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds unit tests back in. It only uses one patient for the tests.
Submitter:
Reviewer 1:
Name:
where appropriate, and accomplishes the task's purpose
Reviewer 2:
Name:
where appropriate, and accomplishes the task's purpose