Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-508: Prevent html rendering in responses #442

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

Jammjammjamm
Copy link
Contributor

@Jammjammjamm Jammjammjamm commented Mar 20, 2020

The CGI.escapeHTML method doesn't work if the html is escaped unicode. This branch unescapes all escaped unicode in responses so that html is not rendered when displaying responses.

Before:
Screen Shot 2020-03-20 at 11 03 16 AM

After:
Screen Shot 2020-03-20 at 10 58 49 AM

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • n/a Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@Jammjammjamm Jammjammjamm self-assigned this Mar 20, 2020
@arscan arscan merged commit a22579c into development Apr 3, 2020
@Jammjammjamm Jammjammjamm deleted the fi-508-prevent-html-in-responses branch April 3, 2020 17:06
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants