Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-482: Allow error message formatting #445

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

Jammjammjamm
Copy link
Contributor

@Jammjammjamm Jammjammjamm commented Mar 26, 2020

This branch allows markdown formatting of error messages, mainly so that we can have multiline error messages. You will probably need to run this in a private window to load the new css.

Submitter:

  • This pull request describes why these changes were made
  • Internal ticket links to this PR
  • Internal ticket is properly labeled (Community/Program)
  • Internal ticket has a justification for its Community/Program label
  • Code diff has been reviewed for extraneous/missing code
  • n/a Tests are included and test edge cases
  • Tests/code quality metrics have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure
    where appropriate, and accomplishes the task's purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@Jammjammjamm Jammjammjamm added the WIP Work in progress label Mar 26, 2020
@Jammjammjamm Jammjammjamm self-assigned this Mar 26, 2020
Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, no objections.

Screen Shot 2020-03-30 at 2 33 21 PM

@Jammjammjamm Jammjammjamm removed the WIP Work in progress label Apr 1, 2020
@arscan arscan merged commit 943a018 into development Apr 3, 2020
@Jammjammjamm Jammjammjamm deleted the fi-482-format-error-messages branch April 3, 2020 17:01
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants