Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

FI-956: Add Generated Sequence to config.yml #479

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

radamson
Copy link
Contributor

@radamson radamson commented Aug 7, 2020

This PR updates the generate rake task to automatically append the generated module to the configuration. An optional argument allows the user to prevent this from happening.

A ConfigManager class was added to help manage loading, updating and writing the config. I'm not sure if we'll want to use this in more places in the future (instead of App::Endpoint::settings and I figure that may be best left for a future PR as the real goal here is to update the generate task.

Note: Adding the newly generated module to the config will remove and comments in an overwritten yaml file

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed other options that avoid editing config.yml (having a script editing a human-editable config file seems like an anti-pattern), but this works for now and we can look to refactor in the future.

@radamson radamson merged commit cb0f144 into development Aug 7, 2020
@radamson radamson deleted the fi-956-add-generated-module-to-config branch August 7, 2020 19:06
@radamson radamson mentioned this pull request Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants