This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for feedback on:
check_resource_against_profile
vs the existing methodtest_resources_against_profile
. The existing method retrieves references from the database and reads them, which might not be possible with contained resources [1]. I'm sure my implementation could be improved (and the commonality better considered).validate_reference_read_reply
vsvalidate_read_reply
for similar reasons (and the fact that theid
property of the reference doesn't align with the id of the resource referenced[1] "In some circumstances, the content referred to in the resource reference does not have an independent existence apart from the resource that contains it - it cannot be identified independently, and nor can it have its own independent transaction scope." - DSTU2 Contained References