Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

MedicationReference Checking #99

Merged
merged 8 commits into from Nov 14, 2018
Merged

MedicationReference Checking #99

merged 8 commits into from Nov 14, 2018

Conversation

radamson
Copy link
Contributor

@radamson radamson commented Nov 9, 2018

  • d003063 contains style and documentation updates
  • 4274b42 makes existing MedicationStatement tests go over all MedicationStatements, not just the first
  • The rest focuses on reading MedicationReferences provided and evaluating them against the relevant Argonaut Profile

Looking for feedback on:

  • check_resource_against_profile vs the existing method test_resources_against_profile. The existing method retrieves references from the database and reads them, which might not be possible with contained resources [1]. I'm sure my implementation could be improved (and the commonality better considered).

  • validate_reference_read_reply vs validate_read_reply for similar reasons (and the fact that the id property of the reference doesn't align with the id of the resource referenced

[1] "In some circumstances, the content referred to in the resource reference does not have an independent existence apart from the resource that contains it - it cannot be identified independently, and nor can it have its own independent transaction scope." - DSTU2 Contained References

@radamson radamson requested a review from arscan November 9, 2018 14:13
@arscan
Copy link
Contributor

arscan commented Nov 13, 2018

I added a pass option that allows the user to return a message on a pass. Also a few cleanups. Are you ok with my changes @radamson

@radamson radamson changed the title WIP: MedicationReference Checking MedicationReference Checking Nov 13, 2018
@arscan arscan merged commit ecc0a30 into development Nov 14, 2018
@arscan arscan deleted the med_state branch November 14, 2018 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants