Update pushbar.js #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change some methods over to static methods (as they don't need this binding). Replace "current" property (pushbar ID) with "activeBar" to keep track of opened status & have active selector reference. A bit of refactoring
oncebot
reviewed
Jul 17, 2018
pushbar/pushbar.js
Outdated
| const pushbar = Pushbar.findElementById(pushbarId); | ||
| if (!pushbar) return; | ||
|
|
There was a problem hiding this comment.
Need to call the close method here , otherwise you can programmatically open multiple bars and will loose track of the active.
oncebot
reviewed
Jul 17, 2018
pushbar/pushbar.js
Outdated
| const { activeBar } = this; | ||
| if (!activeBar) return; | ||
|
|
There was a problem hiding this comment.
As it's a "closing" event I think it should emit right before the closing starts. So the dispatch close should be here.
|
Hey thanks for the changes, Really appreciate that, I've found 2 issues with the code, let me know what you think. |
|
Alright that should now be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change some methods over to static methods (as they don't need this binding).
Replace "current" property (pushbar ID) with "activeBar" to keep track of opened status & have active selector reference.
A bit of refactoring