Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import SASS from node_modules #2

Closed
jaylandro opened this issue Sep 26, 2017 · 1 comment
Closed

Import SASS from node_modules #2

jaylandro opened this issue Sep 26, 2017 · 1 comment

Comments

@jaylandro
Copy link
Contributor

Love the library, one thing I noticed in the documentation. To properly import SASS from node_modules directory the code should be formatted like @import '~handorgel/src/style';
jaylandro added a commit to jaylandro/handorgel that referenced this issue Sep 26, 2017
@jaylandro
Proper SASS import from node_modules
3ee8d7c 
This addresses this issue: oncode#2
@jaylandro jaylandro mentioned this issue Sep 26, 2017
Merged
oncode added a commit that referenced this issue Sep 28, 2017
@oncode
Update README.md
0fd2667 
Addresses issue #2
@oncode
Copy link
Owner

oncode commented Sep 28, 2017

Thanks for your pull request! This just works if you use webpack/sass-loader to compile your sass files though, but I think it's the common use case. I've also updated the README file.

@oncode oncode closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oncode @jaylandro