Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROLE_CURATOR and update navigation panel according to user role #133

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

calvinlu3
Copy link
Contributor

This is related to oncokb/oncokb#3596

@calvinlu3 calvinlu3 requested a review from zhx828 November 8, 2023 17:44
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

nav={<NavLink to={PAGE_ROUTE.CURATION} />}
/>
)}
{props.isUser && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to give user access to all entity pages for now. But we should differentiate read/write permissions, let's focus on the curation page. I will circle back this later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be further discussed in oncokb/oncokb#3602

@calvinlu3 calvinlu3 merged commit dfb5523 into oncokb:rc Nov 9, 2023
1 check passed
@calvinlu3 calvinlu3 deleted the add-curator-role branch November 9, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants