upgrade node to 20.12.2 #286
Conversation
.eslintrc.json
Outdated
| "@typescript-eslint/no-unsafe-argument": "off", | ||
| "@typescript-eslint/no-unsafe-enum-comparison": "off", | ||
| "@typescript-eslint/no-misused-promises": "off", |
There was a problem hiding this comment.
Just by looking at the name of these tracks, they all sound important. What's the rational of disabling?
There was a problem hiding this comment.
As discussed during standup, I checked which rules would be relatively easy to implement:
Re-enabling @typescript-eslint/no-unsafe-enum-comparison was not too bad so I added that back.
@typescript-eslint/no-unsafe-argument disables the use of any types as arguments, which we do all over the place, so I left it disabled
@typescript-eslint/no-misused-promises checks for multiple conditions, but disallows using async functions as handlers such as many of our onConfirms (since they expect to return void). Thus, I have kept the rule, but disabled errors for that condition. Here is the documentation if interested in checking the other conditions.
Created ticket to address this: https://github.com/oncokb/oncokb-pipeline/issues/346 |
| "oncokb-styles": "^1.5.0", | ||
| "path-browserify": "1.0.1", | ||
| "pluralize": "^8.0.0", | ||
| "rc-tooltip": "^6.1.2", | ||
| "rc-tooltip": "^6.2.0", |
There was a problem hiding this comment.
Can you verify that the tooltips still look fine? I remember there was some issue related to the misalignment of the arrow under the tooltip.
| <span> | ||
| <TextFormat value={data.createdAt} type="date" format={APP_HISTORY_FORMAT} /> | ||
| <span className="mr-2" /> | ||
| <span className="me-2" /> |
There was a problem hiding this comment.
Looks like that starting using start and end rather than left and right to support RTL layouts?
No description provided.