Put finalizers back if the are missing #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2022
Mojachieee
approved these changes
Nov 3, 2022
* Automatic pre-release pipeline * Trigger build * Trigger build * Fix docker pull in actions * Set action dependencies and generate release notes * Set action dependencies and generate release notes * Try to fix release generator action * Generate changelog * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Trigger build * Run release only on main
mhmxs
added a commit
that referenced
this pull request
Nov 5, 2022
* Put finalizers back if the are missing * Release pipeline (#87) * Automatic pre-release pipeline * Trigger build * Trigger build * Fix docker pull in actions * Set action dependencies and generate release notes * Set action dependencies and generate release notes * Try to fix release generator action * Generate changelog * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Trigger build * Run release only on main
mhmxs
added a commit
that referenced
this pull request
Nov 5, 2022
* Put finalizers back if the are missing * Release pipeline (#87) * Automatic pre-release pipeline * Trigger build * Trigger build * Fix docker pull in actions * Set action dependencies and generate release notes * Set action dependencies and generate release notes * Try to fix release generator action * Generate changelog * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Try to fix changelog sinceTag * Trigger build * Run release only on main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DiskConfig deletion removes finalizers. But the project depends on them at many places, so to survive restart properly we have to put finalizers back.
Fixes # (issue)
Type of change
Please check options that are relevant.
Checklist: