-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e workflow update #67
Conversation
adding trivy within e2e workflow remonving trivy from PR trigger
.github/workflows/trivy.yml
Outdated
@@ -25,7 +23,7 @@ jobs: | |||
- name: Run Trivy vulnerability scanner | |||
uses: aquasecurity/trivy-action@2a2157eb22c08c9a1fac99263430307b8d1bc7a2 | |||
with: | |||
image-ref: ghcr.io/ondat/trousseau:${{ github.sha }}' | |||
image-ref: ghcr.io/ondat/trousseau:latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please describe why latest
is the best to use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the trivy.yml for ondemand only as there is a dedicated definition for the e2e and I pointed to latest for that purpose.
Would you put instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing special, i just feel cold using latest, because some systems always pulls the latest from the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have the trivy vulnerability scanning done for every PR, we can potentially remove this ondemand scan
bumping the actions version
adding trivy within e2e workflow
remonving trivy from PR trigger