Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Santhe - compliance check #215

Open
sandeepshahi opened this issue May 8, 2023 · 0 comments
Open

Santhe - compliance check #215

sandeepshahi opened this issue May 8, 2023 · 0 comments

Comments

@sandeepshahi
Copy link
Member

Flow 1

/search

  • context/ttl should PT30S as per the API Contract
  • search by item should be implemented (for logs clearance) as per the API contract

/select

  • /message/order/items/fulfillment_id is an invalid attribute

/init

  • billing.created_at should match context.timestamp
  • billing.updated_at should match context.timestamp
  • items/fulfillment_id should match with fulfillment id created in /on_select
  • /fulfillments/id should match with the fulfillment id created in /on_select
  • items/location_id is not required
  • billing/address/area_code is not a valid pincode

/confirm

  • '@ondc/org/buyer_app_finder_fee_type' must be "percent" instead of "percentage"
  • billing object mismatches in /init and /confirm (name is different)
  • /quote/breakup must have item's unit price

/status

  • context/ttl is missing.

/update

/update (refund)

  • settlement_amount calculation is incorrect

Flow 2, 3, 4

  • similar issues as Flow 1

Flow 5

/cancel

@suhas-int

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant