Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for S3 bucket backend #262

Merged
merged 3 commits into from Nov 15, 2017
Merged

Support for S3 bucket backend #262

merged 3 commits into from Nov 15, 2017

Conversation

kawamanza
Copy link
Contributor

No description provided.

@ondras
Copy link
Owner

ondras commented Nov 15, 2017

Hi @kawamanza,

thanks for this PR! Please do not make the php-s3 backend default in config.js. As soon as you fix this, I will happily merge your PR.

@kawamanza
Copy link
Contributor Author

@ondras reverted. Congratulations for your project. Great job!

@ondras
Copy link
Owner

ondras commented Nov 15, 2017

Cool. thanks a lot!

@ondras ondras merged commit c454824 into ondras:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kawamanza @ondras