Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the last_enqueue_time for a job can be ambiguous in format #202

Closed
alecjacobs5401 opened this issue Jun 7, 2018 · 3 comments
Closed

Comments

@alecjacobs5401
Copy link

alecjacobs5401 commented Jun 7, 2018

Sidekiq::Cron::Job#save_last_enqueue_time just passes the @last_enqueue_time to hset for the redis connection, which is calling to_s on the Time object.

If you're using a non-standard default string format for Time objects, then parsing the last_enqueue_time will raise with the following error:

ArgumentError: Ambiguous parse format

Edit: Actually looks like this was fixed in the master branch..but not updated in any of the release versions. Any updates?

@ondrejbartas
Copy link
Collaborator

@alecjacobs5401 this is fixed in v1.0.4

@ondrejbartas
Copy link
Collaborator

please close it if it is resolved

@alecjacobs5401
Copy link
Author

@ondrejbartas

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants