Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent language support. #184

Merged
merged 8 commits into from
Sep 7, 2020
Merged

More consistent language support. #184

merged 8 commits into from
Sep 7, 2020

Conversation

Unthrottled
Copy link
Collaborator

Motivation

I am procrastinating on my other projects.

So I ran through:

  • IntelliJ Idea Ultimate
  • PHP Storm
  • Rider
  • CLion
  • WebStorm

Looking for things that haven't been colored. Here's what I found:

Screens

Before After
Annotation 2020-08-30 135529 Annotation 2020-08-30 140645
Annotation 2020-08-30 143354 Annotation 2020-08-30 143342
Annotation 2020-08-30 143440 Annotation 2020-08-30 143804
Annotation 2020-08-30 144257 Annotation 2020-08-30 144127
Annotation 2020-08-30 145120 Annotation 2020-08-30 145624
Annotation 2020-08-30 152506 Annotation 2020-08-30 152855
Annotation 2020-08-30 160135 Annotation 2020-08-30 160354

Copy link
Collaborator

@mskelton mskelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@Unthrottled
Copy link
Collaborator Author

Just to manage expectations. I've got a couple of thing I want to take care of before I merge this in. I'll probably have some time later this week to get it in. Thanks!

@Unthrottled
Copy link
Collaborator Author

Alright, I'm going to target Monday the 7th for this release. 🎉

@Unthrottled Unthrottled merged commit e7c8eb0 into master Sep 7, 2020
@Unthrottled Unthrottled deleted the consistencyUpdates branch September 7, 2020 13:33
@jelinski
Copy link

First of all thanks for this cool theme! I really like it, however there is one issue I'd like to report.

Built in themes like Darcula visualize commits that are not part of current branch by highlighting them. Unfortunately this feature is not working with "One Dark theme" where all the commits look the same regardless if "Current branch" highlighting is selected or not. Below I post a screenshot.

comparison

Do you know if this is something I can easily tweak on my own? Or maybe there is a chance this will be fixed in next releases of the theme?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants