Web SDK 109101 changes: #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jasonpang
commented
Jan 26, 2016
jasonpang
commented
- Notifications are now tagged by app ID; only one notif will show at a time
- Added icon param to OneSignal._sendSelfNotification()
- Bumped require Safari version to > 7, from > 6
added 5 commits
January 25, 2016 20:24
- Notifications are now tagged by app ID; only one notif will show at a time - Added icon param to OneSignal._sendSelfNotification() - Bumped require Safari version to > 7, from > 6
|
Reviewed 4 of 6 files at r1, 2 of 2 files at r2. Comments from the review on Reviewable.io |
|
src/sdk.js, line 1222 [r1] (raw file): Comments from the review on Reviewable.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.