Add support for ECS Clusters #28

flavioelawi · 2023-10-28T13:33:57Z

This PR introduces basic support for listing ECS Clusters

#22

flavioelawi · 2023-10-28T13:35:07Z

This PR lacks unit tests

Add ecs-service screen

flavioelawi · 2023-11-07T17:19:09Z

thanks for the help on this PR!
anything you need from me for this iteration?

Add ecs-container screen

RamanaReddy0M · 2023-11-22T17:33:37Z

@flavioelawi can you test the flow(clusters -> services -> tasks -> containers) and confirm it as working expected?

flavioelawi · 2023-11-23T17:09:37Z

I can get to the task view, pressing Enter causes an exception

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1057d7fa0]

RamanaReddy0M · 2023-11-23T17:12:27Z

@flavioelawi can you include full logs?

flavioelawi · 2023-11-23T17:14:35Z

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1010e7fa0]

goroutine 1 [running]:
github.com/derailed/tview.(*Application).Run.func1()
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/application.go:243 +0x4c
panic({0x101daf5a0?, 0x102adef50?})
        /opt/homebrew/Cellar/go/1.21.0/libexec/src/runtime/panic.go:914 +0x218
github.com/one2nc/cloudlens/internal/render.EcsContainers.Render({}, {0x101f428c0?, 0x140009a68c0?}, {0x0?, 0x30a8?}, 0x140006a6100)
        /Users/flavioelawi/workspaces/cloudlens/internal/render/ecs_container.go:41 +0x240
github.com/one2nc/cloudlens/internal/model.hydrate({0x0, 0x0}, {0x14000e66a50?, 0x3, 0x14000e921c0?}, {0x140006a6100, 0x3, 0x10060fc8c?}, {0x101f9b430, 0x102b51b40})
        /Users/flavioelawi/workspaces/cloudlens/internal/model/table.go:218 +0xb8
github.com/one2nc/cloudlens/internal/model.(*Table).reconcile(0x14000dddc20, {0x101fa6d28, 0x14000691dd0})
        /Users/flavioelawi/workspaces/cloudlens/internal/model/table.go:163 +0x104
github.com/one2nc/cloudlens/internal/model.(*Table).refresh(0x14000e83578?, {0x101fa6d28?, 0x14000691dd0?})
        /Users/flavioelawi/workspaces/cloudlens/internal/model/table.go:137 +0x28
github.com/one2nc/cloudlens/internal/model.(*Table).Refresh(0x14000691da0?, {0x101fa6d28?, 0x14000691dd0?})
        /Users/flavioelawi/workspaces/cloudlens/internal/model/table.go:99 +0x24
github.com/one2nc/cloudlens/internal/view.(*Browser).Start(0x14000691da0)
        /Users/flavioelawi/workspaces/cloudlens/internal/view/browser.go:60 +0x68
github.com/one2nc/cloudlens/internal/view.(*PageStack).StackPushed(0x14000a82da0, {0x12be81b80, 0x140007ce0e0})
        /Users/flavioelawi/workspaces/cloudlens/internal/view/page_stack.go:36 +0x30
github.com/one2nc/cloudlens/internal/model.(*Stack).notify(0x14000a865f0, 0x1, {0x12be81b80, 0x140007ce0e0})
        /Users/flavioelawi/workspaces/cloudlens/internal/model/stack.go:173 +0x104
github.com/one2nc/cloudlens/internal/model.(*Stack).Push(0x14000a865f0, {0x12be81b80?, 0x140007ce0e0})
        /Users/flavioelawi/workspaces/cloudlens/internal/model/stack.go:99 +0x14c
github.com/one2nc/cloudlens/internal/view.(*App).inject(0x14000a89860, {0x12be81b80, 0x140007ce0e0})
        /Users/flavioelawi/workspaces/cloudlens/internal/view/app.go:456 +0x104
github.com/one2nc/cloudlens/internal/view.(*EcsTask).enterCmd(0x140007ceb40, 0x14000e83896?)
        /Users/flavioelawi/workspaces/cloudlens/internal/view/ecs_task.go:49 +0x1bc
github.com/one2nc/cloudlens/internal/view.(*Table).keyboard(0x18?, 0x140007ce0c0)
        /Users/flavioelawi/workspaces/cloudlens/internal/view/table.go:81 +0xb4
github.com/one2nc/cloudlens/internal/view.(*Browser).InputHandler.(*Table).InputHandler.(*Box).WrapInputHandler.func2(0x14000e83928?, 0x101181f90?)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/box.go:179 +0x3c
github.com/one2nc/cloudlens/internal/view.(*PageStack).InputHandler.(*Pages).InputHandler.func1(0x129d29118?, 0x140006910b0?)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/pages.go:332 +0xa8
github.com/one2nc/cloudlens/internal/view.(*PageStack).InputHandler.(*Pages).InputHandler.(*Box).WrapInputHandler.func2(0x14000e839a8?, 0x100b58c60?)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/box.go:182 +0x54
github.com/derailed/tview.(*Flex).InputHandler.func1(0x14000e83a38?, 0x4?)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/flex.go:261 +0xd0
github.com/derailed/tview.(*Flex).InputHandler.(*Box).WrapInputHandler.func2(0x140006911d0?, 0x544c?)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/box.go:182 +0x54
github.com/one2nc/cloudlens/internal/ui.(*Pages).InputHandler.(*Pages).InputHandler.func1(0x10?, 0x101e19720?)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/pages.go:332 +0xa8
github.com/one2nc/cloudlens/internal/ui.(*Pages).InputHandler.(*Pages).InputHandler.(*Box).WrapInputHandler.func2(0x14000e83ba0?, 0x14000e83ae0?)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/box.go:182 +0x54
github.com/derailed/tview.(*Application).Run(0x140003660e0)
        /Users/flavioelawi/go/pkg/mod/github.com/derailed/tview@v0.7.2/application.go:334 +0x470
github.com/one2nc/cloudlens/internal/view.(*App).Run(0x14000a89860)
        /Users/flavioelawi/workspaces/cloudlens/internal/view/app.go:281 +0x7c
github.com/one2nc/cloudlens/cmd.initView()
        /Users/flavioelawi/workspaces/cloudlens/cmd/root.go:57 +0x98
github.com/one2nc/cloudlens/cmd.selectAWS()
        /Users/flavioelawi/workspaces/cloudlens/cmd/aws.go:38 +0x134
github.com/one2nc/cloudlens/cmd.awsCommand.func1(0x14000202400?, {0x1016b768b?, 0x4?, 0x1016b768f?})
        /Users/flavioelawi/workspaces/cloudlens/cmd/aws.go:17 +0x1c
github.com/spf13/cobra.(*Command).execute(0x14000ab8c00, {0x14000a80f80, 0x4, 0x4})
        /Users/flavioelawi/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x640
github.com/spf13/cobra.(*Command).ExecuteC(0x102af47a0)
        /Users/flavioelawi/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x320
github.com/spf13/cobra.(*Command).Execute(...)
        /Users/flavioelawi/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
github.com/one2nc/cloudlens/cmd.Execute()
        /Users/flavioelawi/workspaces/cloudlens/cmd/root.go:44 +0x54
main.main()
        /Users/flavioelawi/workspaces/cloudlens/main.go:8 +0x1c

RamanaReddy0M · 2023-11-23T17:22:46Z

@flavioelawi can you please pull and try now?

flavioelawi · 2023-11-23T17:51:56Z

Cool, it works, I get to the containers and at the end to the Describe response

RamanaReddy0M

lgtm!

flavioelawi force-pushed the main branch 3 times, most recently from e1d099e to bde51a6 Compare October 28, 2023 21:03

Add ECS Clusters support

b6dae5f

flavioelawi force-pushed the main branch from bde51a6 to b6dae5f Compare October 28, 2023 21:06

jdk2588 requested review from RamanaReddy0M and PratikJethe October 30, 2023 07:32

resolve merge conflicts

b3d073b

RamanaReddy0M linked an issue Nov 3, 2023 that may be closed by this pull request

Project status and ECS Support #22

Closed

RamanaReddy0M assigned flavioelawi Nov 3, 2023

RamanaReddy0M added the enhancement New feature or request label Nov 3, 2023

Add describe event to ecs screen

eb78b4e

Add ecs-service screen

RamanaReddy0M added 2 commits November 21, 2023 21:43

Resolve merge conflicts

54722b2

Add ecs-task screen

41fe621

Add ecs-container screen

fix panic on ecs-container screen

598cd73

Add nil pre checks for ecs-task render

66e3eda

itlumee approved these changes Nov 24, 2023

View reviewed changes

RamanaReddy0M approved these changes Nov 24, 2023

View reviewed changes

RamanaReddy0M changed the base branch from main to dev November 27, 2023 05:54

Merge remote-tracking branch 'upstream/dev'

cfc42b0

RamanaReddy0M merged commit 63660b4 into one2nc:dev Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ECS Clusters #28

Add support for ECS Clusters #28

flavioelawi commented Oct 28, 2023 •

edited

flavioelawi commented Oct 28, 2023

flavioelawi commented Nov 7, 2023

RamanaReddy0M commented Nov 22, 2023

flavioelawi commented Nov 23, 2023

RamanaReddy0M commented Nov 23, 2023 •

edited

flavioelawi commented Nov 23, 2023

RamanaReddy0M commented Nov 23, 2023

flavioelawi commented Nov 23, 2023

RamanaReddy0M left a comment

Add support for ECS Clusters #28

Add support for ECS Clusters #28

Conversation

flavioelawi commented Oct 28, 2023 • edited

flavioelawi commented Oct 28, 2023

flavioelawi commented Nov 7, 2023

RamanaReddy0M commented Nov 22, 2023

flavioelawi commented Nov 23, 2023

RamanaReddy0M commented Nov 23, 2023 • edited

flavioelawi commented Nov 23, 2023

RamanaReddy0M commented Nov 23, 2023

flavioelawi commented Nov 23, 2023

RamanaReddy0M left a comment

Choose a reason for hiding this comment

flavioelawi commented Oct 28, 2023 •

edited

RamanaReddy0M commented Nov 23, 2023 •

edited