Basic statistics algorithm for sparse data #2548

inteldimitrius · 2023-10-13T12:59:11Z

Description

Implemented:

basic statistics algorithm, calculating: min, max, sum, sum squares, sum squares centered, variance, standard deviation, variation and second order raw moment using csr_table
tests
test engine's random csr table generation

cpp/oneapi/dal/algo/basic_statistics/backend/gpu/compute_kernel_csr_impl.hpp

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel_sparse.cpp

cpp/oneapi/dal/algo/basic_statistics/backend/gpu/compute_kernel_csr_impl.hpp

cpp/oneapi/dal/algo/basic_statistics/backend/gpu/compute_kernel_csr_impl_dpc.cpp

cpp/oneapi/dal/algo/basic_statistics/backend/gpu/compute_kernel_sparse_dpc.cpp

cpp/oneapi/dal/algo/basic_statistics/common.hpp

cpp/oneapi/dal/test/engine/csr_table_builder.hpp

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel_sparse.cpp

cpp/oneapi/dal/algo/basic_statistics/backend/gpu/compute_kernel_csr_impl.hpp

cpp/oneapi/dal/algo/basic_statistics/backend/gpu/compute_kernel_csr_impl_dpc.cpp

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel_sparse.cpp

Vika-F

Thank you for adding first sparse algorithm that works on GPU into oneDAL!

The code looks good in general.
My biggest concerns are the level of code commenting and code duplications in CPU implementation.

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel_sparse.cpp

cpp/oneapi/dal/algo/basic_statistics/backend/gpu/compute_kernel_csr_impl_dpc.cpp

cpp/oneapi/dal/algo/basic_statistics/test/batch.cpp

cpp/oneapi/dal/algo/basic_statistics/test/fixture.hpp

cpp/oneapi/dal/table/csr.cpp

cpp/oneapi/dal/test/engine/csr_table_builder.hpp

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel.cpp

Vika-F

LGTM

inteldimitrius · 2023-11-23T12:08:04Z

/intelci: run

KulikovNikita reviewed Oct 13, 2023

View reviewed changes

Vika-F self-requested a review October 16, 2023 08:53

inteldimitrius force-pushed the dev_dmitriyo_csr_lom branch 2 times, most recently from 9c50984 to aa7122b Compare October 27, 2023 17:00

inteldimitrius marked this pull request as ready for review October 27, 2023 17:09

inteldimitrius requested review from Alexsandruss, samir-nasibli and Alexandr-Solovev as code owners October 27, 2023 17:09

Alexandr-Solovev reviewed Oct 28, 2023

View reviewed changes

inteldimitrius requested review from napetrov, homksei, ahuber21 and ethanglaser as code owners November 2, 2023 12:15

Alexandr-Solovev reviewed Nov 2, 2023

View reviewed changes

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel_sparse.cpp Outdated Show resolved Hide resolved

inteldimitrius force-pushed the dev_dmitriyo_csr_lom branch from bfb2c33 to fc4d01a Compare November 3, 2023 13:09

Vika-F reviewed Nov 9, 2023

View reviewed changes

icfaust added the enhancement label Nov 10, 2023

inteldimitrius added 13 commits November 16, 2023 07:02

Add basic statistics csr prototype

a06de9b

Add new files

4b8214b

Dispatching added

1d36af8

add files

f6aac64

Add csr random generation to test engine and minor algo's updates

33b3fe4

Working version without full testing

a23ca77

Add CSR table builder in test engine

a84046c

Minor refactoring

e4059f6

Tests and algorithm is ready

c48c49a

Fix host test failures: set csr generation to one based

50e7e4f

Add copy constructor for csr_table and minor refactoring

f46b79a

Minor refactoring

e48265b

Apply clang-format

68a12dc

inteldimitrius added 21 commits November 16, 2023 07:03

Minor fixes

809f39b

Minor code suggestion from PR

66e0ae3

Add distributed mode

bd3c685

Apply suggestions

6db0653

DAAL kernel debugging

5292452

Add primitives to BUILD

c9082bf

Add primitives to BUILD

978ad12

Add debug prints

ec4c5c7

Fix public CI test failure. Undefined behaviour with nanf

b291f0b

remove reduntant includes

d8a493f

Specify USM memory type for accessor

ed51dc0

Minor updates: add doc comment, update table init for csr_builder

6f33825

Change dispatching for basic statistics from compiletime to runtime

bade955

Apply clang-format and add asserts

2cf2817

Update main kernel

88f76fb

Code cleaning

b6f25c7

Apply clang-format

c1a1f81

Apply PR's suggestions

b07c6be

Kernel optimizations

8cc60cd

Update test table generation (remove primitives from test namespace)

b6a1282

Remove temporary copy constructor from csr table

4898d50

inteldimitrius force-pushed the dev_dmitriyo_csr_lom branch from 0e525d9 to 4898d50 Compare November 16, 2023 15:04

inteldimitrius added 2 commits November 17, 2023 03:03

Proper rebase on master

58dcf7a

Add more test cases

f573b53

Vika-F reviewed Nov 21, 2023

View reviewed changes

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel.cpp Outdated Show resolved Hide resolved

Vika-F reviewed Nov 21, 2023

View reviewed changes

cpp/oneapi/dal/algo/basic_statistics/backend/cpu/compute_kernel.cpp Outdated Show resolved Hide resolved

Change kernel dispatching for CPU

d42d236

Vika-F approved these changes Nov 22, 2023

View reviewed changes

inteldimitrius merged commit d1ed4fd into oneapi-src:master Nov 22, 2023
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic statistics algorithm for sparse data #2548

Basic statistics algorithm for sparse data #2548

inteldimitrius commented Oct 13, 2023

Vika-F left a comment

Vika-F left a comment

inteldimitrius commented Nov 23, 2023

Basic statistics algorithm for sparse data #2548

Basic statistics algorithm for sparse data #2548

Conversation

inteldimitrius commented Oct 13, 2023

Description

Vika-F left a comment

Choose a reason for hiding this comment

Vika-F left a comment

Choose a reason for hiding this comment

inteldimitrius commented Nov 23, 2023