[bug] Fix oneDALConfig.cmake.in for daal examples using a daal-only build #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
napetrov
reviewed
Oct 25, 2023
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
Vika-F
approved these changes
Nov 14, 2023
napetrov
approved these changes
Nov 14, 2023
|
Good question, the cleanest way I would imagine would be to split the build step for daal and oneDAL, then test for daal-specific stuff in between. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
using a "make daal" oneDAL build with the daal examples will fail due to a missing onedal_parameters library. daal does not depend on this library, and so it erroneously will cause the cmake generation to fail. This change allows for daal-only builds to run examples.
Changes proposed in this pull request: