Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ARM(SVE) CPU support with reference backend #2614
Enable ARM(SVE) CPU support with reference backend #2614
Changes from all commits
270cd0f
1eb1c9d
7107ec2
b7926f3
9139d2b
d157592
864e15e
53fff91
bc9d0cf
737c083
6328902
ab24899
eb78bfc
034e0e4
9bebaed
637884c
9057a4e
3452423
aff1938
712c3fe
dd2f543
dfddeab
dfe4b0d
386b0e1
0bb39cc
a916e25
1266cfe
7318d5f
70fede4
4ac729e
82d12b6
0e08af8
206e364
118014c
8ec8a2f
275e448
ae52b5e
4da3196
56d97fa
6b822fe
fbad7de
d749850
811baf4
d1c4c89
39a11bc
31931c3
b58708d
0631fc0
8cb5d35
caf85cd
2321a99
0366fb2
02cc4a3
ef840fd
f91ce0c
9ac2c65
2801ac0
2f51bdb
05c0d99
1049fb7
48914e1
875e349
5e02867
f096211
69fdade
70f5b3a
8b24d4d
bc0bd16
1b22c0d
d83725b
067aef3
7bf3655
163fd52
1a583e7
a765d97
de34cf7
b96ff60
e53115d
b86d408
7fbf4ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CpuTypeEnable
is only used in a few locations, and it feels like it is duplicating some of the other definitions. Maybe something to have a look at in another pull request, but as there is already theCpuType
enum defined in this file, and it could be changed to have the same functionality as required here by defining an extra item in the enum:And then, where necessary, we can use the identifier for the default CPU instead. @napetrov what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vika-F might be remember more, why there is CpuType and CpuTypeEnable.
I think this is along lines of - we might use not matching codepath on cpu. i.e. cpu would be avx512 but we will be forcing sse2 ISA.