[enhancement] Add finiteness_checker algo to cpp/oneapi/dal/algo
#2781
+964
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icfaust
requested review from
Alexsandruss,
samir-nasibli and
Alexandr-Solovev
as code owners
cpp/oneapi/dal/algo/finiteness_checker/backend/cpu/compute_kernel.hpp
Outdated
Show resolved
Hide resolved
cpp/oneapi/dal/algo/finiteness_checker/backend/gpu/compute_kernel_dense_dpc.cpp
Show resolved
Hide resolved
cpp/oneapi/dal/algo/finiteness_checker/backend/gpu/compute_kernel_dense_dpc.cpp
Outdated
Show resolved
Hide resolved
| const compute_input<Task>& input) const; | ||
| compute_result<Task> operator()(const dal::backend::context_cpu& ctx, | ||
| const detail::descriptor_base<Task>& params, | ||
| const compute_input<Task>& input) const; | ||
|
|
||
| #ifdef ONEDAL_DATA_PARALLEL |
There was a problem hiding this comment.
Do we want to have it, or it can be deleted?
There was a problem hiding this comment.
it was about
void operator()(const dal::backend::context_cpu& ctx,
const detail::descriptor_base& params,
const table& data,
bool& res) const;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a finiteness checker algorithm to oneDAL which allows for GPU finiteness checking via reduction_1d. This follows the architecture seen in DBSCAN, covariance, rbf_kernel and linear_kernel.
Changes proposed in this pull request:
Tasks