Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: cpu: aarch64: Enable JIT'ed SVE 128 and 256 support for Eltwise … #1445

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

cfRod
Copy link
Contributor

@cfRod cfRod commented Aug 25, 2022

…primitives

Description

This PR covers minor changes to enable support for Eltwise primitives for SVE 128 and SVE 256 using the JIT'ed implementation originally added to support SVE 512 (#1092).

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Performance improvements

  • [ N/A] Have you submitted performance data that demonstrates performance improvements?

New features

  • Have you published an RFC for the new feature?
  • Was the RFC approved?
  • [N/A] Have you added relevant tests?

Bug fixes

  • [N/A] Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • [N/A] Have you added relevant regression tests?

RFC PR

  • [N/A] Does RFC document follow the template?
  • [N/A] Have you added a link to the rendered document?

@cfRod
Copy link
Contributor Author

cfRod commented Aug 25, 2022

@kawakami-k, we noticed the entry for CPU_INSTANCE_AARCH64(jit_uni_eltwise_bwd_t<sve_512, f32>) for the eltwise backward pass inside the "forward" block of the eltwise implementation list (cpu_eltwise_cpp L64). I have moved this to the backward block.

  • We have tested this on SVE-128 and SVE-256 and found no problems. It would be great if you can see any potential problems with this or extending it to int data types, and also extending it to ASIMD.

@kawakami-k
Copy link
Contributor

@cfRod
Thanks for the patch. I will check it in my environment.

@igorsafo igorsafo merged commit 3c0655c into oneapi-src:master Sep 6, 2022
@igorsafo
Copy link
Contributor

igorsafo commented Sep 6, 2022

@cfRod The changes landed into master and rls-v2.7. Thanks for your contribution!

@igorsafo igorsafo added this to the v2.7 milestone Sep 6, 2022
@cfRod
Copy link
Contributor Author

cfRod commented Sep 7, 2022

Thanks @igorsafo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants