cpu: sycl: bugfix engine creation #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densamoilov
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs that were recently introduced to main and prevent running benchdnn tests on Nvidia and AMD backends. Both bugs cause creation of CPU SYCL engine to fail. They are:
kindofsycl_engine_base_tis hardcoded toengine_kind::gpumaking it impossible to create a CPU SYCL engine. This was introduced in commit 6e24838are_equalfunction for devices is not enabled when SYCL is selected for CPU backend, but it should be. This was introduced in commit ae1dbfe