[Dynamic Selection] Customization - Design approach for free function that calls member if available or default other #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AnuyaWelling2801
commented
Jul 21, 2023
AnuyaWelling2801
commented
- Added default free functions for invoke, invoke with a handle and invoke async
- Implemented customizations for invoke, invoke with a handle and invoke async, so that if a policy implemented any of these functions it would be redirected to the policy's member function.
- Removed the policy wrapper.
AnuyaWelling2801
requested review from
vossmjp,
timmiesmith,
akukanov,
rarutyun,
MikeDvorskiy,
ValentinaKats and
egfefey
AnuyaWelling2801
changed the title
vossmjp
reviewed
Jul 28, 2023
| auto report(const Property &prop, const Value &value) const { | ||
| return const_cast<const scoring_policy_t &>(*scoring_policy_).report(prop, value); | ||
| else { | ||
| return invoke_async(std::forward<DSPolicy>(dp), std::forward<DSPolicy>(dp).select(std::forward<Function>(f), std::forward<Args>(args)...), std::forward<Function>(f), std::forward<Args>(args)...); |
There was a problem hiding this comment.
You are forwarding both f and args twice in the same function. Might be ok, but you should be sure they can never be moved in a call to select.
| auto get_wait_list(){ | ||
| return scoring_policy_->get_wait_list(); | ||
| else{ | ||
| return wait(std::forward<DSPolicy>(dp).invoke_async(std::forward<DSPolicy>(dp).select(std::forward<Function>(f), std::forward<Args>(args)...), std::forward<Function>(f), std::forward<Args>(args)...)); |
There was a problem hiding this comment.
Same possible issue with double forwarding.
AnuyaWelling2801
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.