Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KT] Create and use common defines in esimd radix sort #1049

Conversation

SergeyKopienko
Copy link
Contributor

In this PR we create and use common defines in esimd radix sort :

  • constexpr int DATA_PER_STEP = 16; - use it instead of const 16 in code;
  • namespace __dpl_esimd_ns = sycl::ext::intel::esimd; - use it instead of namespace names __ESIMD_NS an sycl::ext::intel::esimd in code;
  • namespace __dpl_esimd_ens = sycl::ext::intel::experimental::esimd; - use it instead of namespace names __ESIMD_ENS an sycl::ext::intel::experimental::esimd in code;

@dmitriy-sobolev dmitriy-sobolev changed the title Create and use common defines in esimd radix sort [KT] Create and use common defines in esimd radix sort Aug 11, 2023
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SergeyKopienko SergeyKopienko merged commit 1fb62f3 into esimd-radix-sort Aug 11, 2023
@SergeyKopienko SergeyKopienko deleted the dev/skopienko/esimd/esimd-radix-sort_extract_common_defs branch August 11, 2023 15:46
joeatodd pushed a commit to AidanBeltonS/oneDPL that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants