-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KT] Create and use common defines in esimd radix sort #1049
Merged
SergeyKopienko
merged 6 commits into
esimd-radix-sort
from
dev/skopienko/esimd/esimd-radix-sort_extract_common_defs
Aug 11, 2023
Merged
[KT] Create and use common defines in esimd radix sort #1049
SergeyKopienko
merged 6 commits into
esimd-radix-sort
from
dev/skopienko/esimd/esimd-radix-sort_extract_common_defs
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te and using DATA_PER_STEP instead const 16
… and using DATA_PER_STEP instead of const 16
…act BinsPerStep const in RankSLM
…ental/kt/esimd_radix_sort_utils.h
…sycl::ext::intel::esimd
…d sycl::ext::intel::experimental::esimd
dmitriy-sobolev
changed the title
Create and use common defines in esimd radix sort
[KT] Create and use common defines in esimd radix sort
Aug 11, 2023
dmitriy-sobolev
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
SergeyKopienko
deleted the
dev/skopienko/esimd/esimd-radix-sort_extract_common_defs
branch
August 11, 2023 15:46
SergeyKopienko
added a commit
that referenced
this pull request
Aug 16, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Aug 29, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Aug 30, 2023
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Aug 30, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Aug 31, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 1, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 4, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 6, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 7, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 8, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 8, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 11, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 11, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 12, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 13, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 13, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 14, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 14, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 14, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 19, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 19, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 22, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Sep 29, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 4, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 5, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 6, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 9, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 12, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 12, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 16, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 18, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 19, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 23, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 24, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Oct 25, 2023
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Oct 31, 2023
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Nov 1, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Nov 3, 2023
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Nov 8, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Nov 8, 2023
SergeyKopienko
added a commit
that referenced
this pull request
Nov 13, 2023
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Nov 16, 2023
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Nov 21, 2023
dmitriy-sobolev
pushed a commit
that referenced
this pull request
Nov 28, 2023
joeatodd
pushed a commit
to AidanBeltonS/oneDPL
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we create and use common defines in esimd radix sort :
constexpr int DATA_PER_STEP = 16;
- use it instead of const16
in code;namespace __dpl_esimd_ns = sycl::ext::intel::esimd;
- use it instead of namespace names__ESIMD_NS
ansycl::ext::intel::esimd
in code;namespace __dpl_esimd_ens = sycl::ext::intel::experimental::esimd;
- use it instead of namespace names__ESIMD_ENS
ansycl::ext::intel::experimental::esimd
in code;