-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Shorten sycl_iterator and permutation_iterator tests #1552
Conversation
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Note: This does not do anything to address time spent in JIT. |
Should we think about ability to save previous behavior when the macros |
Yes, perhaps with a we can do a min / max with the scale factor of 1.0 when |
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
I've now made it so when |
Actually... it looks like TEST_LONG_RUN=1 is used in the nightly testing, so it kind of defeats the purpose of this PR to turn off the savings in this case if our goal is to speed up the full suite testing. |
I'm tempted to undo my TEST_LONG_RUN changes so we can take advantage of the savings in the nightly suite. @timmiesmith @SergeyKopienko What are your thoughts? |
This reverts commit 6cf6be4.
I've reverted this change, because the point is to provide savings to the nightly suite. We can examine this further, perhaps we want some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds infrastructure to be able to shorten some commonly used test infrastructure by
max_n
(100000) andsmall_n
(16)This also corrects a potential error in the search_20 test of
sycl_iterator_find
which for some value of n, could return the incorrect result due to a unintentional extension of the searched for list by the nature of the input data.A few tests were scaled in this PR to have fewer iterations with different sizes:
sycl_iterator_find
sycl_iterator_reduce
sycl_iterator_scan
sycl_iterator_sort
permutation_iterator_parallel_merge
permutation_iterator_parallel_stable_sort
Others were just given the opportunity for similar shortening.
These patterns should also be tested via their individual tests, independently from the
sycl_iterator
type or thepermutation_iterator
types. Also, the newly addedinput_data_sweep
tests, provide much more coverage for input data processing todpcpp
backends.