Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citation to scan kernel template documentation #1597

Merged
merged 2 commits into from
May 21, 2024

Conversation

adamfidel
Copy link
Contributor

This PR adds a citation for decoupled lookback.

@adamfidel adamfidel requested a review from dcbenito May 21, 2024 15:43
danhoeflinger
danhoeflinger previously approved these changes May 21, 2024
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think I was wrong about my capitalization comments.

Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dcbenito
dcbenito previously approved these changes May 21, 2024
Copy link
Contributor

@dcbenito dcbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went to the paper, and it should be capitalized. Please cite it as: Merrill, D., Garland, M.: Single-pass Parallel Prefix Scan with Decoupled Look-back. Technical Report NVR-2016-002, NVIDIA (2016)

Once that is fixed, I approve this PR.

Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving after capitalization.

@adamfidel adamfidel merged commit 9717d64 into main May 21, 2024
20 checks passed
@adamfidel adamfidel deleted the dev/adamfidel/scan_kt_docs_citation branch May 21, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants