[dpc++][ranges] adjacent_find, none_of, swap_ranges, copy_if... #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
from
8e34720
to
c82358c
Compare
|
Seems not all algorithms are covered by tests. Do you plan to add tests for them to the patch? |
Yes, I'm going to add the missed tests. |
MikeDvorskiy
changed the title
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
2 times, most recently
from
750f04c
to
7a596f5
Compare
MikeDvorskiy
changed the title
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
from
21fdd24
to
ace3e9a
Compare
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
5 times, most recently
from
44ea00e
to
ac05de3
Compare
rarutyun
reviewed
May 11, 2021
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
from
a0f99e2
to
60f3f96
Compare
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
3 times, most recently
from
16e11d0
to
3d57394
Compare
rarutyun
reviewed
May 13, 2021
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
5 times, most recently
from
6622184
to
da29051
Compare
…ue, unique_copy, and the tests
…g ranges with different sizes
…get_kernel_bundle" This reverts commit 450cff1.
MikeDvorskiy
force-pushed
the
dev/mdvorski/ranges_algo_April_theses
branch
from
11d5db9
to
3681f3e
Compare
rarutyun
approved these changes
May 24, 2021
ValentinaKats
pushed a commit
that referenced
this pull request
May 25, 2021
* [dpc++][ranges] + none_of, adjacent_find * [dpc++][ranges] + copy_if, swap_ranges * [dpc++][ranges] + remove_copy, remove_copy_if * [dpc++][ranges] + unique, unique_copy * [dpc++][ranges] + clang format and fixing typos * [dpc++][ranges] + fix for none_of * [dpc++][ranges] + test for range-based none_of, adjacent_find * [dpc++][ranges] + reverse, reverse_copy, rotate_copy * [dpc++][ranges] + test for range-based swap_ranges * [dpc++][ranges] + views::host_all - a custom utility for data access in the host * [dpc++][ranges] + test for range-based copy_if * [dpc++][ranges] + using oneapi::dpl::__ranges::views::host_all * + clang format * [dpc++][ranges] + test for range-based remove_copy, remove_copy_if * [dpc++][ranges] + fixes for reverse, reverse_copy, rotate_copy * [dpc++][ranges] + test for range-based rotate_copy * [dpc++][pstl][tests] + EXPECT_EQ_RANGES utility * [dpc++][ranges] + fix for range-based rotate_copy * [dpc++][ranges] + range-based versions of reverse, reverse_copy, unique, unique_copy, and the tests * [dpc++][ranges][tests] + minor fixes * [dpc++][pstl][tests] + fix for test utils * [dpc++][ranges] + fix a typo; - extra empty lines * [dpc++][ranges] + using nano::subrange * [dpc++][ranges] + fix for range-based replace_copy, replace_copy_if * [dpc++][ranges] + tests for replace_copy, replace_copy_if * + clang format * [dpc++][pstl][tests] + minor change for copy_if_ranges_sycl.pass.cpp * [dpc++][ranges] + PR202 review comments have been addressed. * [dpc++][ranges] + minor changes in all_view_fn, all_view * [dpc++][ranges][tests] + constexpr * + clang format * [dpc++][ranges] + __get_min_size * [dpc++][ranges] + min size range as first for swap_ranges algorithm * [dpc++][ranges] extension of coverage for swap_ranges algo; processing ranges with different sizes * + clang format * [dpc++][ranges] + a fix for swap_ranges algorithm * [dpc++][ranges] + "test experiment" for swap_ranges_sycl.pass.cpp * [dpc++][ranges] + test coverage improvement (+ a predicate) * [dpc++][ranges] + revert "test experiment" for swap_ranges_sycl.pass.cpp * Revert "[dpc++][sycl] + passing sycl::bundle_state::object for sycl::get_kernel_bundle" This reverts commit 450cff1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dpc++][ranges] adjacent_find, none_of, swap_ranges, copy_if, remove_copy, remove_copy_if, unique, unique_copy, reverse, reverse_copy, rotate_copy